Summary by Octane

New Contracts

No new contracts were added in this PR.

Updated Contracts

• ModularAccountBenchmarkBase.sol: The smart contract now supports an ExecutionInstallDelegate for enhanced modular account execution and bytecode deployment.
• AccountBase.sol: Updated constructor parameter naming for clarity.
• ModularAccount.sol: The smart contract now includes an ExecutionInstallDelegate for enhanced execution installation during initialization.
• ModularAccountBase.sol: Key modifications include initializing with an ExecutionInstallDelegate and making isValidSignature an external function.
• ModuleManagerInternals.sol: The smart contract modification refactors how ValidationStorage is accessed, streamlining the retrieval process for module entities.
• SemiModularAccount7702.sol: The smart contract now includes an ExecutionInstallDelegate in the constructor for enhanced functionality and delegation.
• SemiModularAccountBase.sol: Added ExecutionInstallDelegate for modular construction and initialization in the constructor.
• SemiModularAccountBytecode.sol: The smart contract now includes "ExecutionInstallDelegate" integration and an updated constructor for enhanced modular functionality.
• SemiModularAccountStorageOnly.sol: Added ExecutionInstallDelegate to constructor for enhanced execution management in SemiModularAccountStorageOnly.
• ExecutionLib.sol: Modified loop iteration in post hook execution for optimization.
• AllowlistModule.sol: The for-loop increment in functions changed from i++ to ++i for optimization.
• NativeTokenLimitModule.sol: Increment iteration style changed in loops within batch execution logic.
• AccountTestBase.sol: Incorporated ExecutionInstallDelegate for enhanced execution management in account deployment processes.
• OptimizedTest.sol: Modifications include adding ExecutionInstallDelegate for deploying accounts, enhancing modular account creation, and adding deployment functions.

🔗 Commit Hash: 4cd254a

Contract sizes:

 | Contract                      | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
 |-------------------------------|------------------|-------------------|--------------------|---------------------|
 | AccountFactory                |            6,121 |             6,595 |             18,455 |              42,557 |
 | AllowlistModule               |            9,553 |             9,580 |             15,023 |              39,572 |
 | ExecutionInstallDelegate      |            5,947 |             5,993 |             18,629 |              43,159 |
-| ModularAccount                |           22,401 |            29,480 |              2,175 |              19,672 |
+| ModularAccount                |           22,481 |            23,537 |              2,095 |              25,615 |
 | NativeFunctionDelegate        |              560 |               587 |             24,016 |              48,565 |
 | NativeTokenLimitModule        |            4,498 |             4,525 |             20,078 |              44,627 |
 | PaymasterGuardModule          |            1,845 |             1,872 |             22,731 |              47,280 |
-| SemiModularAccount7702        |           23,315 |            30,387 |              1,261 |              18,765 |
-| SemiModularAccountBytecode    |           23,797 |            30,876 |                779 |              18,276 |
-| SemiModularAccountStorageOnly |           24,279 |            31,358 |                297 |              17,794 |
+| SemiModularAccount7702        |           23,395 |            24,444 |              1,181 |              24,708 |
+| SemiModularAccountBytecode    |           23,877 |            24,933 |                699 |              24,219 |
+| SemiModularAccountStorageOnly |           24,359 |            25,415 |                217 |              23,737 |
 | SingleSignerValidationModule  |            3,646 |             3,673 |             20,930 |              45,479 |
 | TimeRangeModule               |            2,085 |             2,112 |             22,491 |              47,040 |
 | WebAuthnValidationModule      |            7,854 |             7,881 |             16,722 |              41,271 |

Code coverage:

Overview

Detailed findings

src/account/ModularAccount.sol

• Review potential Missing Access Control issue that is exposed in the initializeWithValidation function

src/account/ModularAccountBase.sol

• Review potential Denial of Service issue that is exposed in the isValidSignature function

src/modules/permissions/AllowlistModule.sol

• Review potential Missing Access Control issue that is exposed in the deleteAllowlist function
• Review potential Missing Access Control issue that is exposed in the onInstall function
• Review potential Missing Access Control issue that is exposed in the updateAllowlist function
• Review potential Validation Check Does Not Fall Through issue that is exposed in the onUninstall function

🔗 Commit Hash: 4cd254a
🛡️ Octane Dashboard: All vulnerabilities

• fix: [QS-S3] Minor gas optimizations and consistency #305 👈 (View in Graphite)
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.